microsoft / playwright-dotnet

.NET version of the Playwright testing and automation library.
https://playwright.dev/dotnet/
MIT License
2.45k stars 232 forks source link

[Bug]: Playwright running in .NET hosted services seems to leak memory #2962

Open mu88 opened 2 months ago

mu88 commented 2 months ago

Version

1.45.0

Steps to reproduce

  1. Clone my repro repo: https://github.com/mu88/Repro_Playwright
  2. Run dotnet build
  3. Run pwsh Web\bin\Debug\net8.0\playwright.ps1 install
  4. Run the app (either via IDE or dotnet run)
  5. Check the app's log output whether a screenshot is created every 15 s (log message info: NewScreenshotCreator[0] Screenshot created)
  6. Attach a memory profiler to the app (e.g. dotMemory)
  7. Create a first memory dump
  8. Wait some time, e.g. 15 min
  9. Create another memory dump

Expected behavior

The app should not use more memory over time (both managed and unmanaged).

Actual behavior

The app uses more memory over time (both managed and unmanaged).

Additional context

I quickly analyzed one memory dump. Without further understanding of what's going on in Playwright internally, I don't want to speculate about the unmanaged memory. For the managed memory, however, I already discovered the following:

In the following screenshot, you see the increasing memory footprint over time:

2024-07-17_11h06_15

In the next screenshot, you see the dominating types retaining the memory (last memory dump taken):

2024-07-17_11h06_55

And last but not least, the following screenshot shows several issues, e.g. duplicate strings, sparse arrays, and leaking event handlers:

2024-07-17_11h07_42

Environment

- Operating System: Windows 10, Windows 11, WSL2, Linux (Raspberry Pi)
- CPU: arm64, amd64
- Browser: All
- .NET Version (TFM): [net8.0]
mxschmitt commented 2 months ago

Thank your for your bug report. When running it via VS on Windows, it gave me these results:

Screenshot 2024-07-22 at 14 43 25

The increased heap size, seems to be caused by the System.Text.Json cache they have internally. I was before noting two things, try to manually install a recent version of System.Text.Json, it might have some caching fixes included they were doing and the second was that they internally have a timing based cache, which might keep things alive for a few seconds. So GC.Collect() might help.

Also when doing the following, it seems to not leak for me:

using Microsoft.Playwright;

Console.WriteLine($"Started process under PID {System.Diagnostics.Process.GetCurrentProcess().Id}");
while (true) {
    await CreateScreenshotAsync(1920, 1080);
    GC.Collect();
    Console.WriteLine($"TotalMemory: {GC.GetTotalMemory(false)}");
}

async Task CreateScreenshotAsync(uint width, uint height)
{
    using var playwright = await Playwright.CreateAsync();
    await using var browser = await playwright.Chromium.LaunchAsync();
    var page = await browser.NewPageAsync();
    await page.SetViewportSizeAsync((int)width, (int)height);
    await page.GotoAsync("https://playwright.dev/dotnet/");
    await page.ScreenshotAsync(new PageScreenshotOptions { Path = "Screenshot.png", Type = ScreenshotType.Png });
    Console.WriteLine("Screenshot created");
}

Ideally we are able to create a repro without AspNetCore out of it. Do you observe the same without AspNetCore?

mu88 commented 2 months ago

Thank you for getting back to me.

Even when adding GC.Collect() to my ASP.NET Core sample code, the memory slowly increases over time:

image

However, when running a console app with the following code, I don't see this behavior:

using Microsoft.Playwright;

Console.WriteLine($"Started process under PID {System.Diagnostics.Process.GetCurrentProcess().Id}");
PeriodicTimer timer = new(TimeSpan.FromSeconds(15));
while (await timer.WaitForNextTickAsync(CancellationToken.None))
{
    await CreateScreenshotAsync(1920, 1080);
    GC.Collect();
    Console.WriteLine($"TotalMemory: {GC.GetTotalMemory(false)}");
}

async Task CreateScreenshotAsync(uint width, uint height)
{
    using var playwright = await Playwright.CreateAsync();
    await using var browser = await playwright.Chromium.LaunchAsync();
    var page = await browser.NewPageAsync();
    await page.SetViewportSizeAsync((int)width, (int)height);
    await page.GotoAsync("https://playwright.dev/dotnet/");
    await page.ScreenshotAsync(new PageScreenshotOptions { Path = "Screenshot.png", Type = ScreenshotType.Png });
    Console.WriteLine("Screenshot created");
}

image

In case you're asking why I care: due to the problematic behavior in my ASP.NET Core app (see here) which runs on my Raspberry Pi 4 in a docker compose stack with a memory resource limit of 1 GB, I see OOM exceptions after some time due to the continuous increasing memory ☹️ I can also configure a memory limit of 0.5 or 2 GB, it doesn't matter: after some time, all the memory is used.
So far, I can only mitigate this by configuring a restart policy for the Docker container, i.e. the process is more or less like this:

  1. Create a container and create screenshots for a while.
  2. Work, work, work... (with this always use more memory)
  3. Container crash due to insufficient memory
  4. Start a new container and return to step 1

So I see the following follow-up questions:

shuowpro commented 1 month ago

We are facing the similar problem with this, we are using the asp.net core and we are keeping doing the screenshot. the memory is pretty slow, our service will continue leak and eat up all the 8G memory for 2 days.

mu88 commented 1 month ago

@shuowpro: which version of Playwright are you using? I'm now on 1.45.1 and it looks better over the last two weeks:
grafik

Before, it was constantly crashing after some days (each color represents a new container):
grafik

mxschmitt commented 2 weeks ago

I'll close it for now, since this issue is unfortunately not actionable for us. It looks like some bug in ASP.NET whereI recommend filing against them. Thanks for your understanding and happy that it seems resolved!

mu88 commented 4 days ago

@mxschmitt ...and the ASP.NET Core guys will argue the same: it looks like some bug in Playwright 😥

mxschmitt commented 4 days ago

@mu88 do you have a reference to their response? I hope to dedicate some time to it later this week or reach out to some more experienced .NET experts in that area.