search

microsoft / playwright-dotnet

.NET version of the Playwright testing and automation library.
https://playwright.dev/dotnet/
MIT License
2.5k stars 237 forks source link

Update Playwright.csproj to upgrade Microsoft.Bcl.AsyncInterfaces #3010

Closed RaminJolfaei closed 1 week ago

RaminJolfaei commented 1 month ago

upgrade Microsoft.Bcl.AsyncInterfaces to latest version 8.0.0

campersau commented 1 month ago

Is there a specific reason for this? In my opinion libraries should use the lowest version possible since the users can override them by explicitly include the references themselves. This was also done with System.Text.Json here https://github.com/microsoft/playwright-dotnet/pull/2720 Also since System.Text.Json references Microsoft.Bcl.AsyncInterfaces as well, these should be kept in sync.

Meir017 commented 1 month ago

I think as long as our dependencies support netstandard we should be ok updating, see https://www.nuget.org/packages/Microsoft.Bcl.AsyncInterfaces/8.0.0#supportedframeworks-body-tab image

RaminJolfaei commented 1 month ago

My primary reason for upgrading Microsoft.Bcl.AsyncInterfaces to version 8.0.0 is that our DevOps pipeline throws an error during the post-compile step. The pipeline checks DLL references and fails when it doesn’t find version 6 in the bin folder. To resolve this issue and ensure the pipeline can complete successfully, the upgrade to version 8 is necessary. I believe this change will not have any adverse side effects in other environments.

Additionally, most of the other packages we use are now dependent on version 8.0.0 of Microsoft.Bcl.AsyncInterfaces, making this upgrade essential for maintaining compatibility across the project.

mxschmitt commented 1 week ago

Closing as per above - please start with filing an issue with reproduction steps etc. Thank you!