Open nathanielobrown opened 1 year ago
Investigation note, we need to implement this greenlet functionality accordingly around here.
+1 for this. I would like to implement similar feature to consolidate the logs under the same session/request through the same id stored within the contextvars.
When using the Playwright Python library, event callbacks registered with
page.on()
do not have the same contextvars as the parent code. This behavior can lead to issues when users expect shared context between the main code and event handlers.It would be great if Playwright could propagate contextvars to event handlers by default to facilitate shared context.
Reproduction Code Sample:
This code demonstrates failure to get context var. Tested on Python 3.10, Playwright versions 1.31 and 1.29
Context
This came up for me because I used context managers to annotate logs but my logging of network requests in Playwright were not getting annotated.