microsoft / playwright-testing-service

MIT License
70 stars 10 forks source link

[Feature] Expand MPT to Australia-East #94

Closed willbertSmillbert closed 4 months ago

willbertSmillbert commented 4 months ago

Hey - I've been trialing out this service for a week now, using the east asia server and getting mixed results. Some of this may be attributed to latency between me and the Azure service. So opening this up will allow me to make a more fair comparison. Ive also noticed more test flake using MPT. Hopefully this aspect will be resolved with opening it up to the Aus Region.

For reference - Im seeing about a 30% slowness through a single test ran through MPT compared to local.

Could the way Ive written my tests be causing a bottleneck on your resources, leading to slow test execution?

How my tests are set up

-Auth Step to set cookies

-Fully Parallel False

-Page is shared with every test in a file (gets Instantiated in BeforeAll)

Below is some stats comparing local to MPT execution times for the same test suite, all times are derived from the HTML report - The activity log in the MPT dashboard doesnt seem to be accurate

Worker Count Exec Local Exec MPT
6 3-3.5mins ~5mins
10 1.8-2mins 2.8-3mins
20 NA ~2mins

Sorry I went off track a little with regards to the feature request, Just wanted to clarify my situation, to determine if the root cause can be the latency, some other issue on our end or MPT. Or if the outcome is what is expected when using MPT compared to local.

Also - I feel like the performance of MPT is rather inconsistent(seems to be improving though?); difficult to pinpoint though, as test flakiness could be the culprit in this regard

Azure Subscription Id: 15451e06-b6e5-4b64-ada2-1bf419245949

Thanks !

AB#1952247

puagarwa commented 4 months ago

HI @willbertSmillbert thanks for detailed trying out service in detail, Let me explain few things about service and how can we best utilize it.

Service working

Coming back to your results for 6,10 and 20 worker,

Coming to Flaky tests

Few things you can confirm

willbertSmillbert commented 4 months ago

Hey @puagarwa thanks for the reply - If the numbers seem consistent, then Ill assume the performance difference is what it is, thanks for checking your end -

But to answer your questions

Do these timings correlate to what your expectations are - Keep in mind the MPT execution times listed do not include any retries for the runs listed

puagarwa commented 4 months ago

Hi @willbertSmillbert Yes, As i doubted since you are using local machine with 14 core, it can handle load of 10 worker and As i explained its expected that service mode will be slower than non-service when compared with same number of workers.

I assume your major use case is to bring down execution time in CI runs to save time, if thats true then service would help you in CI where you can use worker =10/20 to bring down execution time from 13mins to 2min or less.

However, your initial ask about availability of Australia-East is still valid as that would reduce execution time but still that wont be same as non-service mode.

Other issue that we have to figure out is about flakiness, as i mentioned we need to understand it and try to solve it so that we can reduce the chances of retries.

willbertSmillbert commented 4 months ago

Thanks for the feedback @puagarwa closing as Aus east is already planned