[Docs]: Incorrect description for Frame.name

microsoft / playwright

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

https://playwright.dev

Apache License 2.0

65.39k stars 3.55k forks source link

[Docs]: Incorrect description for Frame.name #30167

Closed rushter closed 2 weeks ago

rushter commented 5 months ago

Page(s)

https://playwright.dev/python/docs/next/api/class-frame#frame-name

Description

The documentation says that it will return frame ID in case there is no name, but the actual code just returns an empty string. https://github.com/microsoft/playwright-python/blob/7e5f197bf0402f7f292a36e5e30fcb75a038a3c2/playwright/_impl/_frame.py#L427

mxschmitt commented 5 months ago

Looks like the same as upstream, hence moving to clarify if its a docs bug or impl bug.

https://github.com/microsoft/playwright/blob/a440800403b2db2b4a29367f9acb46b453df22b5/packages/playwright-core/src/client/frame.ts#L246

rushter commented 5 months ago

Thanks. Just to clarify, there are Frame IDs in CDP, and when I was reading the docs, I thought that I would get such an ID as a result. Perhaps, in Playwright, it is something completely different.

https://chromedevtools.github.io/devtools-protocol/tot/Page/#type-FrameId

pavelfeldman commented 2 weeks ago

Why was this issue closed?

Thank you for your involvement. This issue was closed due to limited engagement (upvotes/activity), lack of recent activity, and insufficient actionability. To maintain a manageable database, we prioritize issues based on these factors.

If you disagree with this closure, please open a new issue and reference this one. More support or clarity on its necessity may prompt a review. Your understanding and cooperation are appreciated.