microsoft / playwright

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
https://playwright.dev
Apache License 2.0
65.86k stars 3.58k forks source link

[internal]: vscode debugging is broken in unreleased version #32710

Closed mxschmitt closed 5 days ago

mxschmitt commented 5 days ago

Not possible to debug todomvc after https://github.com/microsoft/playwright-vscode/commit/4328be9555ecfe8a241e1ed3480e5e2b1866c9cf

Repro: Set a breakpoint in should allow me to add todo items and try to debug it.

mxschmitt commented 5 days ago

Note:

      this._vscode.debug.onDidTerminateDebugSession(() => {
        debugEnd.cancel()
      });

is getting called and causing the debugging session to end.