Closed mxschmitt closed 1 week ago
1 failed :x: [webkit-page] › page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
36894 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:
Merge workflow run.
15 passed :heavy_check_mark::heavy_check_mark::heavy_check_mark:
Merge workflow run.
36892 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:
Merge workflow run.
This PR fixes the following when opening Codegen on https://primevue.org/inputnumber/:
In TypeScript this type is not nullable. This is working as intended from their side: https://github.com/microsoft/TypeScript/issues/50078
Minimal Playwright repro script. This sometimes returns
true
and sometimesfalse
.Contract-wise we have three users of
Highlight::install
:The first one retries every couple of seconds. The other two we expect to be called after the navigation has happened IIUC.
I went over the rest of the code-base, there we usually check for null when interacting with
document.documentElement
.