microsoft / playwright

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
https://playwright.dev
Apache License 2.0
67.12k stars 3.69k forks source link

fix(ui-mode): use onChange instead of onClick for <input type='checkbox' #33636

Closed mxschmitt closed 4 days ago

mxschmitt commented 6 days ago

This fixes:

react-dom.development.js:86 Warning: You provided a `checked` prop to a form field without an `onChange` handler. This will render a read-only field. If the field should be mutable use `defaultChecked`. Otherwise, set either `onChange` or `readOnly`.
    at input
    at label
    at div
    at div
    at div
    at div
    at FiltersView (http://localhost:44223/trace/src/ui/uiModeFiltersView.tsx?t=1731709403821:33:5)
    at MillionProfilerRaw (http://localhost:44223/trace/node_modules/.vite/deps/@million_lint_runtime-dev.js?v=edb77da9:7363:13)
    at div
    at div
    at div
    at SplitView (http://localhost:44223/trace/@fs/Users/maxschmitt/Developer/playwright/packages/web/src/components/splitView.tsx:31:5)
    at MillionProfilerRaw (http://localhost:44223/trace/node_modules/.vite/deps/@million_lint_runtime-dev.js?v=edb77da9:7363:13)
    at div
    at UIModeView (http://localhost:44223/trace/src/ui/uiModeView.tsx?t=1731709403821:70:28)
github-actions[bot] commented 6 days ago

Test results for "tests 1"

1 failed :x: [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

2 flaky :warning: [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @ubuntu-20.04-chromium-tip-of-tree
:warning: [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18

36910 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.