search

microsoft / playwright

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
https://playwright.dev
Apache License 2.0
67.12k stars 3.69k forks source link

fix: dark-mode in UI Mode #33662

Closed mxschmitt closed 3 days ago

mxschmitt commented 3 days ago

Regressed in https://github.com/microsoft/playwright/pull/33350/files#diff-5e8771fb083ee3a9e97263f0a2c0b71134c58c29f7d208e5fd0341577e00c57dR166 instead of adjusting the call-side we should check inside the function if the passed value is truthy so it doesn't hit us in the future again.

Fixes https://github.com/microsoft/playwright/issues/33660

github-actions[bot] commented 3 days ago

Test results for "tests 1"

1 flaky :warning: [webkit-library] › library/screenshot.spec.ts:96:14 › page screenshot › should work with device scale factor and scale:css @webkit-ubuntu-22.04-node18

27826 passed, 463 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] commented 3 days ago

Test results for "tests 1"

15 passed :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] commented 3 days ago

Test results for "tests 1"

1 flaky :warning: [playwright-test] › ui-mode-test-output.spec.ts:80:5 › should show console messages for test @macos-latest-node18-1

36946 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

ScarletMcLearn commented 3 days ago

Hello.

The issue is showing as fixed.

How do I get the changes in my local?

Please suggest.

Thank you.

mxschmitt commented 3 days ago

npm install -D @playwright/test@beta until we have the fix released as 1.49.1.

ScarletMcLearn commented 2 days ago

Thank you @mxschmitt. You rock.

ScarletMcLearn commented 2 days ago

Hello @mxschmitt, the issue is occuring again. Please look into it when you get a chance. Thank you.

mxschmitt commented 2 days ago

Let's continue the discussion in https://github.com/microsoft/playwright/issues/33660#issuecomment-2488366083.