microsoft / playwright

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
https://playwright.dev
Apache License 2.0
67.11k stars 3.69k forks source link

fix: isEditable/toBeEditable throw for elements that cannot be editable/readonly #33713

Open dgozman opened 19 hours ago

dgozman commented 19 hours ago

This is similar to isChecked only allowed for checkable elements.

The list of editable elements includes:

Closes #33697.

github-actions[bot] commented 18 hours ago

Test results for "tests 1"

7 failed :x: [chromium-page] › page/expect-boolean.spec.ts:142:7 › toBeEditable › throws @chromium-ubuntu-22.04-node18 :x: [chromium-page] › page/expect-boolean.spec.ts:142:7 › toBeEditable › throws @chromium-ubuntu-22.04-node20 :x: [chromium-page] › page/expect-boolean.spec.ts:142:7 › toBeEditable › throws @chromium-ubuntu-22.04-node22 :x: [firefox-page] › page/expect-boolean.spec.ts:142:7 › toBeEditable › throws @firefox-ubuntu-22.04-node18 :x: [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1 :x: [chromium-page] › page/expect-boolean.spec.ts:142:7 › toBeEditable › throws @ubuntu-20.04-chromium-tip-of-tree :x: [webkit-page] › page/expect-boolean.spec.ts:142:7 › toBeEditable › throws @webkit-ubuntu-22.04-node18

1 flaky :warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37129 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] commented 16 hours ago

Test results for "tests 1"

3 flaky :warning: [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
:warning: [webkit-library] › library/browsercontext-add-cookies.spec.ts:429:3 › should allow unnamed cookies @webkit-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @windows-latest-node18-1

37134 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.