Closed jperl closed 4 years ago
Reproduced this on Mac, looks like inspector window doesn't like what our new code does with it. I'll have a look at the crash, should be easy to fix.
Note though that support for opening web inspector on the pages controlled by playwright at the moment is very rudimentary. When inspector opens playwright will be disconnected from the browser. This is a limitation of WebKit at the moment and fixing that properly would require adding true mutliclient support there. WebKit folks wanted that as well but it will take some time to get there.
Thanks 🙏. For my use cases (debugging), I do not need playwright to work after opening the web inspector.
Should be fixed now that #736 is merged.
I can confirm it works on the latest master. Thank you for the quick fix 🙏.
@yury-s could you share some details/links about the upstream webkit problem? Specifically, why opening WebInspector stops the Playwright script
When I was trying to debug a test locally (view the console logs/dom) by opening web inspector on webkit, it crashed the browser. Running against this commit https://github.com/microsoft/playwright/commit/fc93b886d9a037a9214e17e298002335122d1054