microsoft / plcrashreporter

Reliable, open-source crash reporting for iOS, macOS and tvOS
Other
2.88k stars 537 forks source link

Use passed value of shouldRegisterUncaughtExceptionHandler instead of YES #237

Closed DmitriyKirakosyan closed 2 years ago

DmitriyKirakosyan commented 2 years ago

Description

This PR fixes the behaviour of PLCrashReporterConfig initialisation that didn't take into account the passed property shouldRegisterUncaughtExceptionHandler in method:

- (instancetype) initWithSignalHandlerType: (PLCrashReporterSignalHandlerType) signalHandlerType
                     symbolicationStrategy: (PLCrashReporterSymbolicationStrategy) symbolicationStrategy
    shouldRegisterUncaughtExceptionHandler: (BOOL) shouldRegisterUncaughtExceptionHandler

Related PRs or issues

AB#92529

236

https://github.com/microsoft/appcenter-sdk-dotnet/issues/1639

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.