Returns the battery level for iOS devices and the free disk space and…

microsoft / plcrashreporter

Reliable, open-source crash reporting for iOS, macOS and tvOS

Other

2.84k stars 532 forks source link

Returns the battery level for iOS devices and the free disk space and… #270

Closed bgustafson closed 1 year ago

bgustafson commented 1 year ago

… memory for all devices in crash reports.

Things to consider before you submit the PR:

[✅ ] Has CHANGELOG.md been updated?
[✅ ] Are tests passing locally?
[✅ ] Are the files formatted correctly?
[ ] Did you add unit tests?
[ ✅] Did you test your change with the sample apps?

Description

The goal of this PR is to return the devices battery level for iOS devices and the free disk space and memory for all device in crash reports.

Related PRs or issues

List related PRs and other issues.

Misc

Add what's missing, notes on what you tested, additional thoughts or questions.

AnatolyPristensky commented 1 year ago

Hello @bgustafson and thank you for your contribution! We will test your changes and update this thread with results.

bgustafson commented 1 year ago

@microsoft-github-policy-service agree company="Splunk"

DmitriyKirakosyan commented 1 year ago

@bgustafson , @landonf

Based on https://github.com/microsoft/plcrashreporter/pull/270#discussion_r1036028846, I don't see any reason to merge this PR for now. The only change that seem to be OK for merging is getting memory info, however this code should be carefully tested with different scenarios to make sure it wouldn't break anything. Due to the complexity of such tests and the risk of failing to collect crash report if anything goes wrong in this method, I would recommend using setCrashCallbacks for now as a workaround.

bgustafson commented 1 year ago

I am going to close this PR. I am going to add this into customData in our project. Thanks for the review though!