search

microsoft / plcrashreporter

Reliable, open-source crash reporting for iOS, macOS and tvOS
Other
2.84k stars 532 forks source link

Added caught exception logging to PLCrashReporter #277

Closed jasminlapalme closed 1 year ago

jasminlapalme commented 1 year ago

Description

I bring back the caught exception logging. I simply cherry-pick the commit 969602123a4e8d124755d1d90b558f94ab1ca6b7 that has been reverted by 48e516013a897438a0699261ca070b0c2da72510.

We use that feature to generate reports from specific exception that have been caught elsewhere in the app.

jasminlapalme commented 1 year ago

@microsoft-github-policy-service agree company="Druide Informatique"

MikhailSuendukov commented 1 year ago

Thank you for your contribution, it will take us some time to check if it mergable.

DmitriyKirakosyan commented 1 year ago

Hi @jasminlapalme , I believe we can get this feature back. Let's cherry-pick the second related commit as well?

jasminlapalme commented 1 year ago

@DmitriyKirakosyan, I cherry-pick the related commit. I think it's all good.

DmitriyKirakosyan commented 1 year ago

@jasminlapalme , the tests are failing because of autorelease: 

❌  /Users/runner/work/1/s/Tests/PLCrashReporterTests.m:61:128: 'autorelease' is unavailable: not available in automatic reference counting mode

❌  /Users/runner/work/1/s/Tests/PLCrashReporterTests.m:69:93: ARC forbids explicit message send of 'autorelease'

❌  /Users/runner/work/1/s/Tests/PLCrashReporterTests.m:69:93: 'autorelease' is unavailable: not available in automatic reference counting mode

Could you check the test locally and fix it?

jasminlapalme commented 1 year ago

I check the test locally and correct it.