microsoft / powerapps-tools

Unsupported PowerApps Tools & Apps
MIT License
1.05k stars 434 forks source link

[BUG]: issue Commented out code in Theming causes errors #1026

Open bcobra opened 3 years ago

bcobra commented 3 years ago

Describe the bug A clear and concise description of what the bug is. Set(SelectedTheme,ThisItem); is commented out in CoE Theme Editor HomeScreen glThemes onSelect. You cannot publish your theme without this code.

Component (please tell us which flow or app you are experiencing issues with):

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen. SelectedTheme to be set onSelect Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

bcobra commented 3 years ago

also the code to update PrimaryColor4 is missing from the Save button in ThemeEditor Screen: Patch(Styles, LookUp(Styles, Name = "PrimaryColor4Value" && Theme.Name = SelectedTheme.Name ),{ Value : LookUp(PaletteGallery.AllItems, Name = "PrimaryColor4Value").ColorPicker.inputValue});

bcobra commented 3 years ago

Actually all PrimaryColor4Value is messed up as it isn't coming thru in my app onStart either: et(PrimaryColor3Value, ColorValue(LookUp(ThemeStyles, Name = "PrimaryColor3Value").Value)); Set(PrimaryColor3TextValue, ColorValue(LookUp(ThemeStyles, Name = "PrimaryColor3TextValue").Value)); Set(defaultLabelColorValue, ColorValue(LookUp(ThemeStyles, Name = "defaultLabelColorValue").Value));