search

microsoft / powerapps-tools

Unsupported PowerApps Tools & Apps
MIT License
1.04k stars 432 forks source link

Code Review tool defaulting all patterns to Not Set #1063

Open SravaniSeethi opened 3 years ago

SravaniSeethi commented 3 years ago

For any review that I upload (msapp file or selecting the app directly), the automated pattern results are being set to “Not Set” except the 4 patterns as shown in attached image. The remaining patterns are not giving the “Pass”/”Fail”. I tried installing both managed and unmanaged versions of v 1.0.0.37 @mehdislaoui @manuelap-msft image

slaouist commented 3 years ago

Thanks for letting us know. We haven't seen this issue before but we will try to repro on our end and fix for next release.(coming in few days)

SravaniSeethi commented 3 years ago

Thank you @mehdislaoui , looking forward to the next version. Just fyi, the automated patterns seemed to have worked in the beginning, but stopped working in the past few days so I it could have been one of the users changing a pattern through the admin tool, etc. I tried looking into the flows but everything seemed normal. Also, another thing to add: the "App settings flag" was always being set to failed even though the keeprecentscreensloaded, enableappembeddingux settings were On. Thanks again!

SravaniSeethi commented 3 years ago

I was able to resolve the issue with the following steps:

  1. From the admin app, I removed the pattern that a user added. It was for detecting unused variables
  2. I also looked through the app checker rules references in the admin tool and found an empty row and removed it After the above 2 steps, I was able to create a new review and the automated results were displayed as expected.

From my understanding the issue was caused due to a user adding a new pattern, which was fine in most cases but somehow they were able to create an empty row in the rules references table that was failing the Request Creation system event.