search

microsoft / powerbi-desktop-samples

Power BI Desktop sample files for the monthly release. Here you can find the PBIX files used in the monthly release videos.
MIT License
1.48k stars 892 forks source link

Report theme JSON schema - Accept comments #55

Closed OscarValerock closed 1 year ago

OscarValerock commented 1 year ago

Hi, would it be possible to add a "comment" field to all the properties?

Before the big release of the new JSON themes, this was possible, unfortunately today, we can't add commments.

Sometimes naming is not intuitive, and it comes in handy for theme development. Thanks!

@yelper

image

yelper commented 1 year ago

There's definitely a balance to be struck here! Part of making the set of properties restrictive is to make it obvious when there's a typo, like you specify "colro": "#001A29" and it errors. Right now, I believe only the textClasses, styles-level of visualStyles (second level), fill rules, icon definitions, and data bars definitions are restrictive.

We believed these to be the places where we should be restrictive to prevent setting properties not known by these types and catch these sort of typos.