search

microsoft / powerbi-visuals-heatmap

powerbi-visuals-heatmap
MIT License
28 stars 27 forks source link

More settings in the formatting pane for customizing visual #118

Closed SanderGi closed 1 year ago

SanderGi commented 1 year ago

What did I do?

Why did I do it this way?

Only being able to adjust font size/family can be limiting, so to allow users across a variety of use cases to make their heatmap visuals look good, these new options have been added.

Anything else you should know?

No localizations have been added for the new features as per request.

Screenshots

Composite font controls and adjustable label margins: image

image image
SanderGi commented 1 year ago

@zBritva there are some misspellings in the translations in stringResources e.g. "symbols" being written as "symbold" in the en-US resources. Should I fix these issues while I add translations for the new controls?

AleksSavelev commented 1 year ago

Looks good to merge

uve commented 1 year ago

Please fix the bugs demonstrated in this visual:

  1. It takes two Tab clicks to select a data point in the selected (Enter) visual,
  2. It takes 5 Tab clicks to go back to the first data point after the last one,
  3. Borders are not fully displayed - some pages may disappear and reappear only after dropping into that data point.

https://github.com/microsoft/powerbi-visuals-heatmap/assets/534586/09accc1e-ce5f-4daf-a384-3663017805cd

uve commented 1 year ago

please resolve conflicts

SanderGi commented 1 year ago

Please fix the bugs demonstrated in this visual:

  1. It takes two Tab clicks to select a data point in the selected (Enter) visual,
  2. It takes 5 Tab clicks to go back to the first data point after the last one,

  3. Borders are not fully displayed - some pages may disappear and reappear only after dropping into that data point.

    heatmap_keyboard.mp4

I believe it is outside the scope of this PR to implement keyboard navigation (there was no interactivity when it was submitted). So I think these bugs which were introduced by the keyboard navigation PR should be fixed in that PR or another PR since this is just adding a few extra inputs in the formatting pane? Here is the keyboard navigation PR: https://github.com/microsoft/powerbi-visuals-heatmap/pull/120. I've reached out to the author of that PR and he'll help fix the bugs

SanderGi commented 1 year ago

please resolve conflicts

I have resolved the conflicts