search

microsoft / powerbi-visuals-histogram

A histogram chart plots data ranges into intervals. Useful for estimating density.
Other
28 stars 32 forks source link

Fixes #21 #55

Open timon-schmelzer-gcx opened 3 years ago

timon-schmelzer-gcx commented 3 years ago

The current version of the visual ignores xaxis boundries. This PR fixes this issue. See plot attached.

Bildschirmfoto 2020-11-24 um 08 43 09

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

timon-schmelzer-gcx commented 3 years ago

Thanks for the feedback!

I guess there are some issues with the currently existing tests. For example, if you set the minimum of the x axis to be 10 and expect it to be 9.71 (which is actually the value which appears in the visual!), something seems to be strange. This might also explain why the x axis is currently not working correctly, although all tests are passed.

All tests have been fixed. I also played around with the actual visual in Power Bi, everything seems fine for me. Please have a look.

No new tests have been added by me because there are already plenty of tests checking the x axis parameters.

helen508light commented 3 years ago

This PR was added to histogram tasks and will be considered together with other tasks