search

microsoft / powerbi-visuals-image-comparison-tests

Image comparison tests for PowerBI CV
MIT License
14 stars 12 forks source link

Make this repo private? #8

Closed deldersveld closed 7 years ago

deldersveld commented 7 years ago

Should this repo be public?

ignatvilesov commented 7 years ago

On Jul 8, 2017 11:22 PM, "David Eldersveld" notifications@github.com wrote:

Should this repo be public?

  • It contains screenshots of two unreleased visuals (Flywheel and PowerKPI)
  • The embedded-reports-urls.config.json file contains links to Publish to Web reports in two environments public doesn't use (dxt and msit)
  • Flywheel Publish to Web report contains non-public data such as the unique number of active BAPI users and info about ISV and SIs

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Microsoft/powerbi-visuals-image-comparison-tests/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AEsxPN6fPZ3EEut8EJsN3qIn8yHFSc6hks5sL-TqgaJpZM4OR22J .

uve commented 7 years ago

All embeds in this repository should contain a sample data only. +@savvinsergey, please look into it. During investigation, I’ll switch this repo to private.

savvinsergey commented 7 years ago

I changed dataset for Flywheel. Now it doesn't contain non-public data