search

microsoft / powercat-creator-kit

This toolkit helps create well-designed Power App experiences on the web & mobile. It contains a component library; PCF controls and other utilities that increase developer productivity.
MIT License
321 stars 53 forks source link

[Creator Starter Kit] BUG: pivotAppCode and Elevation components missing from Creator Kit Reference canvas app as standalone components for reuse #158

Open DeeTrigga opened 2 years ago

DeeTrigga commented 2 years ago

Describe the bug A lot of the the creator kit components use a "sub" component called "pivotAppCode_##". When trying to reuse, this component is lost in the move and it's not available as a standalone component in the reference app. This is needed for the component to work correctly outside the reference app.

To Reproduce Steps to reproduce the behavior:

  1. Create a new canvas app in same environment as the creator kit reference app deployment
  2. Go to Insert ("+") on the left side panel
  3. Click on Get more components
  4. Load "TagPickerBasic" component from the Creator Kit Reference App
  5. Once loaded, right click on it and select "Edit component".
  6. Go to Component tab
  7. Select the component
  8. Here, you'll see the errors, ComponentHeight missing pivotAppCode_17.Selected.ItemKey

Expected behavior Just need to expose the Elevation and pivotAppCode components as standalone so that they can be reused when referenced elsewhere.

Screenshots If applicable, add screenshots to help explain your problem. originalimported Additional context I made sure all the same settings and version were applied that was on the original app to the new to make sure those were not affecting it.

AB#1003

denise-msft commented 2 years ago

@DTrigga85 thanks for the feedback. We are looking into ways where the component implementations are not contained within subcomponents as we architect way to implement the reference apps.

Would it be more helpful for us to expose the underlying implementation for you (outside of components), or are you saying the idea of having the component contained in subcomponents are better, but it was just difficult for you to reuse it in other apps?

DeeTrigga commented 2 years ago

Hi @denisem-msft , personally, I can work with it either way, if embedded as a subcomponent though, it just needs to be transferrable. As it was at that time, the subcomponent was being left out when transferring it which caused the reference error when trying to implement on a separate app. I believe the easier fix for that would be to undo the subcomponent and just use one component container for the entire control so that there is no issue when transferring the control to another app. Or maybe I'm not transferring it in the right way that would keep the subcomponent intact, that could be as well.

Please let me know if you need any clarification.

Thank you!