microsoft / presidio

Context aware, pluggable and customizable data protection and de-identification SDK for text and images
https://microsoft.github.io/presidio
MIT License
3.89k stars 579 forks source link

Current make file throws errors if container registry is undefined (first build only) #192

Closed CodeRunRepeat closed 5 years ago

omri374 commented 5 years ago

Specifically, this error message appears:

Error response from daemon: pull access denied for presidio/presidio-golang-deps, repository does not exist or may require 'docker login'
Makefile:31: recipe for target 'docker-build-deps' failed
make: [docker-build-deps] Error 1 (ignored)
docker pull presidio/presidio-python-deps:'latest'
Error response from daemon: pull access denied for presidio/presidio-python-deps, repository does not exist or may require 'docker login'
Makefile:31: recipe for target 'docker-build-deps' failed
make: [docker-build-deps] Error 1 (ignored)
docker build -t presidio/presidio-golang-deps:'latest'   -f Dockerfile.golang.deps .

Note that this error doesn't mean the process won't run to completion. The make file works even without a defined container registry. During the build process, and error will be written but the build would succeed and the error could be ignored.