microsoft / project-oagents

Experimental AI Agents Framework
Creative Commons Attribution 4.0 International
217 stars 43 forks source link

chore: Update Testcontainers for .NET #5

Open HofmeisterAn opened 9 months ago

HofmeisterAn commented 9 months ago

What does this PR do?

Hi 👋, I noticed that the project is currently using an outdated version of Testcontainers for .NET. This pull request updates the version to the latest release.

Furthermore, this pull request applies Testcontainers' best practices. It is typically preferred to utilize the WithResourceMapping API to copy files into the container rather than binding them. This is especially crucial when dealing with different Docker environments, as binding a volume can sometimes fail, particularly in remote Docker setups. This also eliminates the need to create the temporary script file on the test host.

Furthermore, I have introduced a wait strategy as part of this pull request. Wait strategies are necessary to indicate the readiness of the container (service inside the container) or serving as a status indicator once the container's entry point has completed its execution.

Why is it important?

-

Related issues

-