search

microsoft / promptflow-rag-project-template

An end-to-end sample of RAG showcasing development, evaluation, experimentation, and deployment using Promptflow, search products like CosmosDB, PostgresSQL, and Azure AI Search
MIT License
42 stars 8 forks source link

Hkh/add config node #27

Closed HosseinHeris closed 6 months ago

HosseinHeris commented 6 months ago

[] review param_config [] review configloader node [] review flow and see if configs are used properly [] run notebook as an end2end experimentation [] run local deploy and see if it works as expected. ** note: I think we might need to do something similar with the output so the local deployment does not show as json file.

HosseinHeris commented 6 months ago

@journeyman-msft : having multiple yaml files is very common in software engineering. I personally don't see any issue there. However, I did not run into the issue with the configloader. Need to double check that.

HosseinHeris commented 6 months ago

@journeyman-msft: I think the benefits we are getting from params.yaml approach exceeds the downsides. (1) I think it makes it easier for experimentation and deployment (2) easier for automation. The only downside is the single node running, which will likely resolve by promptflow team. Also, there is a workaround that we can always use the actual values as input for debugging purposes if needed. Another workaround is to use the debugging. I checked and it is compatible with the proposed approach.

HosseinHeris commented 6 months ago

@journeyman-msft: added notes to the readme.