microsoft / promptflow

Build high-quality LLM apps - from prototyping, testing to production deployment and monitoring.

https://microsoft.github.io/promptflow/

MIT License

8.43k stars 725 forks source link

[Draft] Use async scheduler as default scheduler #2291

Closed thy09 closed 2 months ago

thy09 commented 2 months ago

Description

Use async scheduler as default to make sure cancel works well.

All Promptflow Contribution checklist:

[ ] The pull request does not introduce [breaking changes].
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.
[ ] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

github-actions[bot] commented 2 months ago

SDK CLI Global Config Test Result heta/use-async-as-default

2 tests 2 :white_check_mark: 51s :stopwatch: 1 suites 0 :zzz: 1 files 0 :x:

Results for commit 19316c6f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

promptflow-tracing unit test result heta/use-async-as-default

4 files 4 suites 27s :stopwatch: 4 tests 4 :white_check_mark: 0 :zzz: 0 :x: 16 runs 16 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 19316c6f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

promptflow-tracing e2e test result heta/use-async-as-default

4 files 4 suites 1m 43s :stopwatch: 8 tests 8 :white_check_mark: 0 :zzz: 0 :x: 32 runs 32 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 19316c6f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

Executor Unit Test Result heta/use-async-as-default

754 tests 753 :white_check_mark: 57s :stopwatch: 1 suites 0 :zzz: 1 files 1 :x:

For more details on these failures, see this check.

Results for commit 19316c6f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

promptflow SDK CLI Azure E2E Test Result heta/use-async-as-default

4 files 4 suites 3m 44s :stopwatch: 168 tests 149 :white_check_mark: 19 :zzz: 0 :x: 672 runs 596 :white_check_mark: 76 :zzz: 0 :x:

Results for commit 19316c6f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

SDK CLI Test Result heta/use-async-as-default

12 files 12 suites 41m 27s :stopwatch: 451 tests 434 :white_check_mark: 17 :zzz: 0 :x: 1 804 runs 1 736 :white_check_mark: 68 :zzz: 0 :x:

Results for commit 19316c6f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

Executor E2E Test Result heta/use-async-as-default

211 tests 202 :white_check_mark: 9m 13s :stopwatch: 1 suites 2 :zzz: 1 files 7 :x:

For more details on these failures, see this check.

Results for commit 19316c6f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] commented 2 months ago

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.