microsoft / promptflow

Build high-quality LLM apps - from prototyping, testing to production deployment and monitoring.

https://microsoft.github.io/promptflow/

MIT License

8.43k stars 725 forks source link

Redefine Span Relationship in Generator Tracing #3035

Closed liucheng-ms closed 2 weeks ago

liucheng-ms commented 1 month ago

Description

This pull request enhances the span relationship in generator tracing. The change ensures that the span capturing the iteration process of a generator is a child of the span in which the generator is produced. Previously, this relationship was established using a span link field, but now it is related through context parent-child relations. This modification helps track the execution procedure more effectively.

All Promptflow Contribution checklist:

[ ] The pull request does not introduce [breaking changes].
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.
[ ] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

github-actions[bot] commented 1 month ago

promptflow-tracing test result

12 files 12 suites 13s :stopwatch: 58 tests 58 :white_check_mark: 0 :zzz: 0 :x: 696 runs 696 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 93c4b619.

github-actions[bot] commented 1 month ago

promptflow SDK CLI Azure E2E Test Result liucheng/20240426_stream_span

4 files 4 suites 4m 6s :stopwatch: 238 tests 203 :white_check_mark: 35 :zzz: 0 :x: 952 runs 812 :white_check_mark: 140 :zzz: 0 :x:

Results for commit 93c4b619.

github-actions[bot] commented 1 month ago

promptflow-core test result

0 tests 0 :white_check_mark: 0s :stopwatch: 0 suites 0 :zzz: 0 files 0 :x:

Results for commit 93c4b619.

github-actions[bot] commented 1 month ago

SDK CLI Global Config Test Result liucheng/20240426_stream_span

6 tests 6 :white_check_mark: 1m 16s :stopwatch: 1 suites 0 :zzz: 1 files 0 :x:

Results for commit 93c4b619.

github-actions[bot] commented 1 month ago

Executor Unit Test Result liucheng/20240426_stream_span

792 tests 792 :white_check_mark: 3m 43s :stopwatch: 1 suites 0 :zzz: 1 files 0 :x:

Results for commit 93c4b619.

github-actions[bot] commented 1 month ago

Executor E2E Test Result liucheng/20240426_stream_span

241 tests 234 :white_check_mark: 5m 10s :stopwatch: 1 suites 5 :zzz: 1 files 2 :x:

For more details on these failures, see this check.

Results for commit 93c4b619.

github-actions[bot] commented 1 month ago

SDK CLI Test Result liucheng/20240426_stream_span

4 files 4 suites 57m 49s :stopwatch: 663 tests 650 :white_check_mark: 13 :zzz: 0 :x: 2 652 runs 2 600 :white_check_mark: 52 :zzz: 0 :x:

Results for commit 93c4b619.

github-actions[bot] commented 3 weeks ago

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] commented 2 weeks ago

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.