microsoft / promptflow

Build high-quality LLM apps - from prototyping, testing to production deployment and monitoring.

https://microsoft.github.io/promptflow/

MIT License

8.32k stars 712 forks source link

Add util method to summarize trace telemetry. #3074

Closed huaiyan closed 1 week ago

huaiyan commented 2 weeks ago

Description

Add util method to summarize trace count telemetry.

For long term telemetry, we will need span count. The simplest solution is create custom event for each trace id and include span count in custom dimension. But that may generate too many customer events to affect all telemetry. So, we only record trace count first, and decide how to add span count later according to trace count's telemetry. Maybe just decide a reasonable sampling rate.

All Promptflow Contribution checklist:

[ ] The pull request does not introduce [breaking changes].
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.
[ ] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

github-actions[bot] commented 2 weeks ago

promptflow-tracing test result

12 files 12 suites 7m 47s :stopwatch: 19 tests 19 :white_check_mark: 0 :zzz: 0 :x: 228 runs 228 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 8768e80b.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 weeks ago

promptflow SDK CLI Azure E2E Test Result dev/robbenwang_span_telemetry

4 files 4 suites 4m 5s :stopwatch: 238 tests 203 :white_check_mark: 35 :zzz: 0 :x: 952 runs 812 :white_check_mark: 140 :zzz: 0 :x:

Results for commit f6790072.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 weeks ago

promptflow-core test result

0 tests 0 :white_check_mark: 0s :stopwatch: 0 suites 0 :zzz: 0 files 0 :x:

Results for commit f6790072.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 weeks ago

SDK CLI Global Config Test Result dev/robbenwang_span_telemetry

6 tests 6 :white_check_mark: 1m 18s :stopwatch: 1 suites 0 :zzz: 1 files 0 :x:

Results for commit f6790072.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 weeks ago

Executor Unit Test Result dev/robbenwang_span_telemetry

792 tests 792 :white_check_mark: 3m 44s :stopwatch: 1 suites 0 :zzz: 1 files 0 :x:

Results for commit f6790072.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 weeks ago

Executor E2E Test Result dev/robbenwang_span_telemetry

242 tests 237 :white_check_mark: 5m 10s :stopwatch: 1 suites 5 :zzz: 1 files 0 :x:

Results for commit f6790072.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 weeks ago

SDK CLI Test Result dev/robbenwang_span_telemetry

4 files 4 suites 59m 21s :stopwatch: 668 tests 655 :white_check_mark: 13 :zzz: 0 :x: 2 672 runs 2 620 :white_check_mark: 52 :zzz: 0 :x:

Results for commit f6790072.

:recycle: This comment has been updated with latest results.