thy09 commented 2 weeks ago

Description

Refine exec_line logic to support async generator in flow test.

This pull request primarily focuses on improving the handling of generators and asynchronous generators in the promptflow package. The changes ensure that the code can handle both synchronous and asynchronous generators, improve the handling of generator outputs, and refactor the way nodes are executed in the flow.

Here are the key changes:

Improved handling of generators and asynchronous generators:

src/promptflow-core/promptflow/_core/run_tracker.py: The inspect module was imported to replace the use of GeneratorType for checking if a value is a generator. The method update_and_persist_generator_node_runs was introduced to replace persist_selected_node_runs, and it now updates the output of the node run with the output in the trace before persisting it. [1] [2] [3]
src/promptflow-core/promptflow/_utils/run_tracker_utils.py: The inspect module was imported, and the method _deep_copy_and_extract_items_from_generator_proxy was updated to handle AsyncGeneratorProxy and to convert generators to strings to avoid deepcopy errors. [1] [2]

Refactoring of node execution:

src/promptflow-core/promptflow/executor/flow_executor.py: The ThreadPoolExecutorWithContext was imported from promptflow.tracing. In the exec_line method, a check was added to use exec_line_async when the tools are async. The exec_line_async method was updated to include a line_timeout_sec parameter. The _exec_inner_with_trace_async method was updated to use _stringify_generator_output_async to handle async generator output. The _exec_post_process method was updated to use update_and_persist_generator_node_runs instead of persist_selected_node_runs. The _should_use_async method was updated to check if any tool is async. The _traverse_nodes_async method was updated to use an async scheduler. The methods _merge_async_generator, _stringify_generator_output_async, and _merge_generator were added to handle generator outputs. The _submit_to_scheduler method was updated to only use the thread pool mode. [1] [2] [3] [4] [5] [6] [7] [8]

All Promptflow Contribution checklist:

[ ] The pull request does not introduce [breaking changes].
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.
[ ] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

github-actions[bot] commented 2 weeks ago

promptflow SDK CLI Azure E2E Test Result heta/allow-async-generator-flow-test

4 files 4 suites 4m 8s :stopwatch: 238 tests 203 :white_check_mark: 35 :zzz: 0 :x: 952 runs 812 :white_check_mark: 140 :zzz: 0 :x:

Results for commit f54a67fd.