search

microsoft / psi

Platform for Situated Intelligence
https://github.com/microsoft/psi/wiki
Other
529 stars 93 forks source link

Increase Newton.Json version to fix the build error in VS2019: #231

Closed freistli closed 2 years ago

freistli commented 2 years ago

Severity Code Line Description File Project Category Suppression State Tool Error CS1705 1 Assembly 'Microsoft.Psi.Data' with identity 'Microsoft.Psi.Data, Version=0.17.52.1, Culture=neutral, PublicKeyToken=null' uses 'Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' which has a higher version than referenced assembly 'Newtonsoft.Json' with identity 'Newtonsoft.Json, Version=12.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' C:\fork\psi\Sources\Visualization\Microsoft.Psi.Visualization.Windows\CSC Microsoft.Psi.Visualization.Windows Build N/A Compiler

chitsaw commented 2 years ago

Thanks for this PR. I'm curious how you ran into this build error as we don't see it when building in VS2019. From the error text you reported, it says Microsoft.Psi.Data uses Newtonsoft.Json version 13, but that does not appear to be the case and it has been building just fine for us (and other users as well). While in-principle it should be no problem to bump the version as you propose, we'd like to first understand how you encountered this problem to be sure we're not missing anything. Did you modify anything or are you cloning and building directly?