microsoft / psi

Platform for Situated Intelligence
https://github.com/microsoft/psi/wiki
Other
529 stars 93 forks source link

Feature request: Option to record audio with MixedReality UWP's PhotoVideoCamera class #253

Closed austinbhale closed 1 year ago

austinbhale commented 1 year ago

Currently, the only functionality for StreamingCaptureMode is Video: https://github.com/microsoft/psi/blob/7f8f51d3ab87b2d91aa86be1eaa203f17413a9c7/Sources/MixedReality/Microsoft.Psi.MixedReality.UniversalWindows/PhotoVideoCamera.cs#L422

Media capture also offers Audio and AudioAndVideo options - would it be possible to extend this class's functionality to store audio? If this is not in the roadmap, could I work on a pull request for doing so? Thanks.

AshleyF commented 1 year ago

Access to the microphone audio stream is available via the separate Microsoft.Psi.MixedReality.Microphone component. Does this cover your needs?

austinbhale commented 1 year ago

Unfortunately, this component relies on StereoKit's microphone, which is currently unreliable. Please see https://github.com/StereoKit/StereoKit/issues/449 for more information.

I've created a pull request (https://github.com/microsoft/psi/pull/254) that adds the AudioAndVideo option to the current PhotoVideoCamera. This change works for us. Would love to know what you all think