search

microsoft / psi

Platform for Situated Intelligence
https://github.com/microsoft/psi/wiki
Other
538 stars 96 forks source link

Question about "FFMPEGMediaSource.cs" #258

Closed HaozheQi closed 1 year ago

HaozheQi commented 2 years ago

Hi,

I need to build the Microsoft.Psi.Media.Windows.x64 project. From the List of Components page, it seems that FFMPEGMediaSource implemented in FFMPEGMediaSource.cs is not supported by Windows. Then why does the Microsoft.Psi.Media.Windows.x64.csproj still include this components? It will give me a lot of errors when I inlcude this component.

I am looking forward to your reply! Thank you very much!

sandrist commented 2 years ago

If you haven't defined the FFMPEGDir environment variable on your system, then Visual Studio should be able to compile the project without error, because it will skip all the code in the FFMPEGMediaSource.cs due to the #if FFMPEG at the top. Is this not happening in your case? Do you have that environment variable defined for some reason?

That said, you make a good point that the code is currently confusing as written, and it isn't clear if the component would work on Windows today at all, even after pointing to a valid installation of FFMPEG. As you point out in your other issue, it definitely seems to assume a quite old version of FFMPEG that is no longer easy to obtain. We'll look into this, and might consider deprecating the component entirely (or at least the Windows version of it), if it isn't easy to update the code to work with a more current FFMPEG installation and APIs.

chitsaw commented 1 year ago

Resolved 706ae03ba548a4e5696d959050d6476828dde979