microsoft / psi

Platform for Situated Intelligence
https://github.com/microsoft/psi/wiki
Other
538 stars 96 forks source link

PsiStudio not displaying correctly properties with new visualizers #301

Closed AuMilliat closed 6 months ago

AuMilliat commented 7 months ago

Hello,

I'm working on new visualizers for PsiStudio, I have issue getting the property panel working as intended. As an example, I've made a slight modification on the Azure Kinect Visualizer to display confidence as joint color (nothing changes in the properties).

augmented

Expected

azure

From what I understand objects are not seen as expendable.

3D panel

3DView

I probably I'm doing wrong something and it will be fixed with #54

sandrist commented 7 months ago

Can you share some of the new code? Does Skeleton still have the [ExpandableObject] tag above it?

/// <summary>
/// Gets the skeleton visualization object for the body.
/// </summary>
[ExpandableObject]
[DataMember]
[PropertyOrder(3)]
[DisplayName("Skeleton")]
[Description("The body's skeleton properties.")]
public SkeletonVisualizationObject<JointId> Skeleton { get; private set; }
AuMilliat commented 7 months ago

Thanks for the reply,

Here the winmerge of the files (left: modified, right: base) winmerge

I've tried to copy-past the kinect visualization project outside \psi repo and I was able to reproduce the issue:

extract

Integrating my classes inside the \psi repo correct the behavior:

intern

So my guess it's related to dependencies.

AuMilliat commented 7 months ago

I've corrected the issue by doing the link properly with \psi. I've build from the source those two nugets: nuget

It might worth to publish them on nuget.org!

sandrist commented 6 months ago

Thanks for the update! Glad that you are unblocked. In the future we might put more visualizers in nugets and release PsiStudio as an installable executable. For now, we only support PsiStudio and related visualizers to be built from source.