Closed AuMilliat closed 3 weeks ago
@microsoft-github-policy-service agree company="IMT Atlantique"
----- Mail original ----- De: "microsoft-github-policy-service[bot]" @.> À: "microsoft/psi" @.> Cc: "Aurélien MILLIAT" @.>, "Mention" @.> Envoyé: Lundi 23 Septembre 2024 10:31:20 Objet: Re: [microsoft/psi] Compatibility with Unity & Android (PR #330)
@AuMilliat please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
-- Reply to this email directly or view it on GitHub: https://github.com/microsoft/psi/pull/330#issuecomment-2367546534 You are receiving this because you were mentioned.
Message ID: @.***>
Proposed modifications: Adding Microsoft.Psi.InteropAndroid, that is a reduction of Microsoft.Psi.Interop for TCPSource/Writer with a modification of dynamic to template (crash with refecerence exception on Quest).
Microsoft.Psi project modifications: PsiStore path need to be changed for Android and check the permission to write at application level. KnowSerializer instance writeable to allow the addition of ‘serializer’ and public to application level. Mutex downgrade code & Removing null check operator to be compatible with Mono & Android.
Some modifications are unnecessary (or not complete) as the first target was to use Emitters and Receivers (commit ID: 446a0fa7f3d1f4b43b2d0f763e0e879ac7f48ca5).