search

microsoft / pxt-adafruit

Microsoft MakeCode editor for Adafruit Circuit Playground Express
https://makecode.adafruit.com
Other
81 stars 77 forks source link

Play Tone still sounds buzzy #1041

Closed Jaqster closed 5 years ago

Jaqster commented 5 years ago

Audio is much improved!
Although I'm noticing that while the Play Sound melodies all sound very nice, and volume control seems correct, the Play Tone blocks still produce sound that is very "buzzy".
Also, when I put a Play Sound block in a loop, a strange noise sounds between sounds. https://makecode.com/_4igATVd3K7xe

abchatra commented 5 years ago

@mmoskal

mmoskal commented 5 years ago

@Jaqster does this sound less buzzy? (the weird sound between playUntilDone should be gone as well)

binary.zip

Jaqster commented 5 years ago

No, I don't hear any improvement. These are v1.22 firmware boards I'm testing on. Also the Simulator doesn't sound great on the computer either...

abchatra commented 5 years ago

Did this bug got fixed?

mmoskal commented 5 years ago

I don't hear the buzzy sound...

Jaqster commented 5 years ago

I think the Play Tone blocks now sound less buzzy than before. But the weird sound between PlaySoundUntil Done blocks is still there, and I'm not sure the Volume is correct - 255 still sounds quiet to me.

abchatra commented 5 years ago

@Jaqster playTone volume is still low for default and doesn't sound good.

abchatra commented 5 years ago

We have new issues, but closing this old one.