search

microsoft / pxt-adafruit

Microsoft MakeCode editor for Adafruit Circuit Playground Express
https://makecode.adafruit.com
Other
81 stars 77 forks source link

Rainbow animation is super slow #1063

Closed jedgarpark closed 5 years ago

jedgarpark commented 5 years ago

Seems like maybe something changed here, the "rainbow" animation pattern is very, very slow now.

Both in browser simulator and on CPX hardware.

forever(function () { light.showAnimation(light.rainbowAnimation, 500) })

pelikhan commented 5 years ago

This is a recession. Fix coming.

abchatra commented 5 years ago

We should take this as hotfix.

pelikhan commented 5 years ago

I will prepare a PR in master that we can port

pelikhan commented 5 years ago

https://github.com/microsoft/pxt-common-packages/commit/1858239388aac371d2a7ef3752373d2b91326216

abchatra commented 5 years ago

fixed