microsoft / pxt-adafruit

Microsoft MakeCode editor for Adafruit Circuit Playground Express
https://makecode.adafruit.com
Other
81 stars 77 forks source link

When download is pressed, should 'commit' active field editor #1115

Open jwunderl opened 5 years ago

jwunderl commented 5 years ago

Describe the bug

If you make a cool sound in the melody editor, then press download right away to have it run (without collapsing melody editor), the downloaded version will not have your song.

To Reproduce Steps to reproduce the behavior:

  1. Go to adafruit editor (beta)
  2. open melody editor
  3. make a beautiful song
  4. press download without pressing done
  5. downloaded file will have no sound.

Expected behavior

we could potentially 'commit' the action and collapse the field editor when download is pressed, so that the downloaded file contains the melody. (this happens with any field editor, e.g. sprite editor in arcade)

Screenshots

2019-08-30 11 04 22

after this interaction, the downloaded file does nothing