microsoft / pxt-adafruit

Microsoft MakeCode editor for Adafruit Circuit Playground Express
https://makecode.adafruit.com
Other
81 stars 77 forks source link

CPX MakeCode "photon off" is broken #1208

Open ricknun opened 2 years ago

ricknun commented 2 years ago

Describe the bug See the CPX MakeCode defect demonstration program at: https://makecode.com/_DuF8A5XAp8fW

The program header comment includes: In the forever loop set the second photon mode to each choice and observe the simulator and CPX. Pen up (leave prior colors alone), pen down (write the last color set), and eraser (turn pixels off) all make sense. But "off" in the simulator ignores the "photon flip" and continues going forward with pen down, painting the last random color used. "Off" in the CPX hardware shuts off the bright photon as hoped, but forever -- it never comes back on with the next "photon pen down". Also the CPX seems hung at this point and won't program again (using the MS MakeCode for CPX" Windows app).

Expected behavior First, "photon off" should behave the same in the simulator and CPX hardware. Next, it should be documented at https://makecode.adafruit.com/reference/light/set-photon-mode. (It isn't mentioned there.) I would expect "photon off" to turn off the bright white photon and proceed the same as "pen up" -- a way to move the pen without the super-bright white LED.

Desktop (please complete the following information): I am using Windows 10 and the "Microsoft MakeCode for Circuit Playground Express" app.

ricknun commented 2 years ago

Under "Expected behavior" I think it would be better to expect "photon off" to turn off the bright white photon LED and ignore any motion/hue/other commands until put into one of the other 3 modes.