Closed eanders-ms closed 4 years ago
Hm, I remember this being intentional; clicking sign out in the gear menu already signs you out on it's own, but pops up the github signout page as well (https://github.com/logout) to give you the option to sign out of github too. The reasoning was that in classrooms, students would think that signing out of makecode would keep them safe -- but since github was still logged in, anyone else could just reauthorize makecode again.
I believe this is a common ish practice with education apps, or at least we had a few other examples like it -- maybe just a little modal that pops up first saying "we're sending you to github to log out there as well!" before redirecting would be good?
I see how that makes sense for classrooms. Signing out of GitHub navigates the user out of Arcade to the GitHub logout page, where they have the option to sign out everywhere else too.
Describe the bug In Arcade, with my GitHub account linked, if I sign out using the Arcade gear menu, it will sign me out of GitHub in all browser tabs.
To Reproduce
Tab 1 (Arcade):
Tab 2 (GitHub):
Expected behavior GitHub sign-out from Arcade should only affect Arcade, and not affect other tabs.
Desktop