Cloud-sync infinite reload issue

microsoft / pxt-arcade

Arcade game editor based on Microsoft MakeCode

https://arcade.makecode.com

MIT License

477 stars 207 forks source link

Cloud-sync infinite reload issue #3058

Closed darzu closed 3 years ago

darzu commented 3 years ago

The infinite reload is fixed by: https://github.com/microsoft/pxt/pull/7836 however there is still a bug in that it shouldn't have gotten into a state where it tried to reload continuously.

I don't know what the repro steps are yet.

2021-02-05 10 44 35

jwunderl commented 3 years ago

1.3.42 is 2 weeks old / the current live version, you want arcade.makecode.com/stable which will get you 1.3.44. but I also don't think that commit / any of yours from the last 2 weeks have gotten ported to stable6.8 in pxt?

eanders-ms commented 3 years ago

I hit this today in latest release channel (arcade.makecode.com, v1.3.44). Identity is enabled for me in release because it shares experiment flags with beta.

What I did that somehow triggered it:

I was signed in to cloud.
I was not signed into GitHub.
I was editing a new project.
While in the editor, I clicked the GitHub button to save the project to GitHub. Because I wasn't signed in, I started the sign in process. That's when the cloud sync/reload cycle started.

Closing the browser tab and reopening doesn't resolve it. It goes back into the "cloud sync finished. reloading..." cycle.

In the the debug console I see this pattern repeated:

1 more projects found in the cloud.
pxtapp.js:2493 Last cloud project change was 315 seconds ago
pxtapp.js:2493 Cloud sync finished after 2 seconds with 1 local changes.

eanders-ms commented 3 years ago

With dbg=1, there's more detail in the log:

1 more projects found in the cloud.
pxtapp.js:2493 Last cloud project change was 1024 seconds ago
workspace.js:463 workspace: save 'grapplnaut' (8a14bf1b-3fdc-417b-8328-407a11c6f09f)
pxtapp.js:2493 Cloud sync finished after 1 seconds with 1 local changes.

What jumps out at me here is the workspace save of the project 'grapplnaut'. This surprises me because at this point I'm at the home screen. But that was the project I was editing when this whole thing started. Could it have local edits that are failing to sync to the cloud?

eanders-ms commented 3 years ago

Issue doesn't seem to repro in beta channel.

darzu commented 3 years ago

Haven't been able to repro.