Temporary assets no longer listed in order of type

shakao commented 2 years ago

Describe the bug

not a regression. i think the temporary image assets used to be listed after the named image assets, instead of after everything?

BeckHaru commented 2 years ago

Curious, what does the word "temporary" mean? That it will disappear when I leave? What does the "Danger!" icon mean above? If they both mean the sprite hasn't been named, perhaps we can find a better way to communicate this ... right now it feels like there is something dangerously wrong! Maybe we could call it "Unnamed asset"?

shakao commented 2 years ago

@BeckHaru yep, "temporary" is the same as unnamed! behavior-wise, the difference is:

unnamed:

if you delete the block containing an unnamed asset, that image will be gone forever
if you duplicate the block containing an unnamed asset, and edit the new image, you will have two different images

named:

if you delete the block containing a named asset, the image is still present in the "My Assets" tab
if you duplicate the block containing a named asset and edit the new image, the image in BOTH blocks will be changed

it would be great to communicate this visually somehow in the blocks themselves (as well as the asset editor)... kiki has an issue here about how the concept of "temporary" vs named assets is confusing: https://github.com/microsoft/pxt-arcade/issues/3481

microsoft / pxt-arcade

Temporary assets no longer listed in order of type #4581