search

microsoft / pxt-arcade

Arcade game editor based on Microsoft MakeCode
https://arcade.makecode.com
MIT License
482 stars 209 forks source link

Wrong word used in JS code block for isHittingTile method (should be "wall") #4984

Open bmarslandCN opened 2 years ago

bmarslandCN commented 2 years ago

Describe the bug In the JS editor, the is (mySprite) hitting wall (direction) code block turns into text that says mySprite.isHittingTile( ) but we believe it should say mySprite.isHittingWall( ) to match the description on the JS code block and the blocks version of this code.

To Reproduce Steps to reproduce the behavior:

  1. Go to the JS editor in MakeCode Arcade
  2. In Scene, find the is (mySprite) hitting wall (direction) block, then drag the block out into the coding area
  3. The block turns into the JS text mySprite.isHittingTile( )
  4. The documentation under the code block in the menu, as well as the pop up documentation box, also use the word "tile"

Expected behavior We expected the word "tile" to be replaced by the word "wall" in the code and the documentation since the code is checking if the sprite is hitting a wall tile

Screenshots Code block and documentation in the Scene category: image

JS code as it appears in the coding area when dragged out: image

Desktop (please complete the following information):

Additional context Please let us know if this behavior is intentional and not a bug @riknoll 😄

abchatra commented 2 years ago

@riknoll opinion here?