microsoft / pxt-arcade

Arcade game editor based on Microsoft MakeCode
https://arcade.makecode.com
MIT License
477 stars 206 forks source link

Ship color palette experiment #5327

Closed abchatra closed 1 year ago

abchatra commented 1 year ago

I would like to ship color palette experiment in Jan release. image

However currently it is hidden in settings->project settings image image

Richard and I think the right home for this in asset editor image

image

abchatra commented 1 year ago

@riknoll FYI

abchatra commented 1 year ago

@Jaqster FYI

clkantner commented 1 year ago

Weighing in here - I think that spot is a much better, less hidden place, on board with the proposed location.

abchatra commented 1 year ago

Thanks. It is possible to come up with figma for laptop/iPad/iPhone form factor?

clkantner commented 1 year ago

So sorry I am getting to this late, here are some explorations I have done.

Firstly, with our initial idea, it works fine for Desktop and iPad, but on mobile it might have to move under Asset preview. Also, the 'edit' icon on the right may be confusing to users (might not make the connection it's to edit the palette, unless we have an icon that looks more like specifically editing a color palette) Screenshot 2022-11-09 at 10 14 20 PM Screenshot 2022-11-09 at 10 14 58 PM Screenshot 2022-11-09 at 10 15 16 PM

Another idea is to consolidate color palette into a single button. It saves spaces, reduces confusion with the edit icon, and removes having multiple buttons. However, we would have to redesign the edit dialogue to accomadate both editing and selecting palettes. It could look something like this: Screenshot 2022-11-09 at 10 16 58 PM Screenshot 2022-11-09 at 10 16 34 PM Screenshot 2022-11-09 at 10 16 40 PM Screenshot 2022-11-09 at 10 16 46 PM

Would love to know any thoughts. @abritez feel free to chime in as well!

clkantner commented 1 year ago

Oh another thing, I think saying "Project Color Palette" feels redundant, and we could just say "Color Palette"

abchatra commented 1 year ago

Combining into a single button as "Color Palette" looks neat to me. Thanks so much @clkantner

unthinkmedia commented 1 year ago

Is this something that needs to be decided right now? Can we take a moment to think about project setting holistically, or may explore a wider variety of options?

abchatra commented 1 year ago

This is shipping color palette feature. I think redesigning project settings is a separate feature. I am not sure how they are related.

unthinkmedia commented 1 year ago

It relates in the fact that by adding focus to one button you will in turn reduce focus of another. I would like to not rush into a design decision without first thinking about the UIs impact on other jobs.

On Thu, Nov 10, 2022 at 11:36 AM Abhijith Chatra @.***> wrote:

This is shipping color palette feature. I think redesigning project settings is a separate feature. I am not sure how they are related.

— Reply to this email directly, view it on GitHub https://github.com/microsoft/pxt-arcade/issues/5327#issuecomment-1310572151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN2LTVRRDJ6OWHMPXGVO5H3WHUQB7ANCNFSM6AAAAAAR3XF6PY . You are receiving this because you commented.Message ID: @.***>

abchatra commented 1 year ago

Any alternative suggestions?

kiki-lee commented 1 year ago

I love where this discussion is going! On the subject of editing palettes, the convention with a dropdown menu is to have a "New" or "Custom" option that allows you to create your own version. I think that would remove the need for the edit button.

Jaqster commented 1 year ago

What about putting it in the Image editors? Feels like the most discoverable place...
image

abchatra commented 1 year ago

I worry about putting the palette in the sprite editor. As it changes all other sprites too and not just this sprite. It is a global setting at the asset level.

Jaqster commented 1 year ago

We could have a warning about this changing everything in the project, or maybe it's a link that points you to Project-level Settings? My Assets is a gallery of completed assets. It's not really where you go to create. Users will want to choose their colors when they're creating.

Jaqster commented 1 year ago

Maybe we could test out a couple different options with students and see what we find?

abchatra commented 1 year ago

In my opinion we don't want every kid to tinker with the colors. They will not look good compared to default ones and all the sprites in the galleries will be messed up (they change too) and completely unusable. This is for hero students who want a completely different palette like wakanda.

abchatra commented 1 year ago

I am sure it is more discoverable in the sprite editor.

abchatra commented 1 year ago

One other scenario is skillmap were changing the palette there will cause all the my assets (which we add as part of the tutorial) will change too. Also, next tutorial being a new project will revert back to the original palette.

unthinkmedia commented 1 year ago

It sounds like this is an advanced user option. Typically advance user options intentionally require a bit of friction to find, meaning we probably want to keep away from using primary buttons that compete with the core jobs of that page. The core jobs is locating an asset, secondary is probably going to gallery to find provided images, so this should be a tertiary CTA from a visual presence perspective. That would mean that it is less discoverable, which is exactly what we want in this situation.

On Thu, Nov 10, 2022 at 12:38 PM Abhijith Chatra @.***> wrote:

One other scenario is skillmap were changing the palette there will cause all the my assets (which we add as part of the tutorial) will change too. Also, next tutorial being a new project will revert back to the original palette.

— Reply to this email directly, view it on GitHub https://github.com/microsoft/pxt-arcade/issues/5327#issuecomment-1310654968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN2LTVT3E6WU4LHUESXEMQ3WHUXLBANCNFSM6AAAAAAR3XF6PY . You are receiving this because you commented.Message ID: @.***>

Jaqster commented 1 year ago

that's true