mp in editor: connected/disconnected events should fire when presence icon clicked

microsoft / pxt-arcade

Arcade game editor based on Microsoft MakeCode

https://arcade.makecode.com

MIT License

477 stars 207 forks source link

mp in editor: connected/disconnected events should fire when presence icon clicked #5625

Open eanders-ms opened 1 year ago

eanders-ms commented 1 year ago

To make editor behavior more consistent with online multiplayer:

send "connected" for player 1 at game startup (I think it already does this)
when a presence icon is clicked, send "connected" for that player and "disconnected" for all other players except player 1. player 1 is always connected.

jwunderl commented 1 year ago

I can make it so it sends on click, but I definitely would prefer to avoid sending disconnected on clicking another one -- that'd make it real hard to test any game that relies on it, and I don't think I'd view clicking 'play as 3' to correspond to 'disconnect player 2' / would definitely feel like a bug

eanders-ms commented 1 year ago

We need a way to test disconnected events.

eanders-ms commented 1 year ago

In the future we might want a toggle for "connected" and a separate way to indicate whether they're the current player (where input is piped).

eanders-ms commented 1 year ago

Without sending disconnect events it will be impossible to test a connect more than one time per user per game session. And never possible to test disconnects.