search

microsoft / pxt-arcade

Arcade game editor based on Microsoft MakeCode
https://arcade.makecode.com
MIT License
484 stars 210 forks source link

Named sprites not working properly in tutorials #5767

Closed kiki-lee closed 5 days ago

kiki-lee commented 1 year ago

When assets are loaded using assetjson (as in nearly all skillmaps) there's an issue for the reference if they're changed.

Microsoft Edge - MakeCode Skill Map 2023-03-08 at 1 22 03 PM

This is happening on all browsers on my mac. Also many different tutorials. It also seems to be happening no matter which block you try using the image in.

This is a very dangerous one. Please fix ASAP.

jwunderl commented 1 year ago

pointer over to https://github.com/kiki-lee/mole-images/pull/1, though we should think on a more holistic fix for this sort of thing.

abchatra commented 1 year ago

Fixed

kiki-lee commented 1 year ago

I don't believe this is officially fixed. We have a hackaround, but it's not ideal. Sounds like there's a way to change the way things are loaded to fix authentically (or maybe we can give sprites namespaces?)

Sounds like it won't be a lot of work, it will just need some attention.

abchatra commented 1 year ago

@jwunderl ?

abchatra commented 1 year ago

@kiki-lee I don't know how to reproduce this now. Can you add a repro?

kiki-lee commented 1 year ago

Sure.

1) Visit https://arcade.makecode.com/#tutorial:/graveyard/skillmap/adventure/adventure3_old 2) Click on the image of the lute in the code 3) Choose a new image from the gallery 4) See the Lute still show up on the game screen

kiki-lee commented 5 days ago

This should be fixed with the new Asset Pack imports