search

microsoft / pxt-arcade

Arcade game editor based on Microsoft MakeCode
https://arcade.makecode.com
MIT License
477 stars 207 forks source link

Kiosk: delete game button not getting highlighted on down button pressed #6136

Closed srietkerk closed 10 months ago

srietkerk commented 11 months ago

The delete game button underneath user-added games does not get highlighted when using keyboard navigation. The button gets an outline when a user hovers over the button with a mouse, but the outline does not get applied with keyboard navigation.

To Reproduce Steps to reproduce the behavior:

  1. Upload a game to kiosk
  2. Navigate to that game
  3. See the delete button underneath the game
  4. Use the arrows or WASD keys to navigate to the delete button
  5. Nothing gets outlined but if you press A, you will trigger the deletion modal

Expected behavior Using the keyboard should highlight the delete game button.

image

Desktop (please complete the following information):

abchatra commented 11 months ago

This is fixed. We have square around it now.

abchatra commented 11 months ago

Reopened as it still reproes in some browsers. But didn't repro in the arcade cabinet.