microsoft / pxt-arcade

Arcade game editor based on Microsoft MakeCode
https://arcade.makecode.com
MIT License
477 stars 206 forks source link

Breaking change from v1.12.43 to v1.12.44 - Simulator? #6315

Open Vegz78 opened 8 months ago

Vegz78 commented 8 months ago

Describe the bug From v1.12.44 and onwards, there has been introduced a breaking change where controlling a MakeCode Arcade game with some bluetooth HID devices causes the game/simulator to reset/blink and eventually freeze instead of controlling the game.

Might it have something to do with the "Bump pxt-arcade-sim -> v0.11.9", or maybe some other "cherry pick kiosk commits(#6152)" by @eanders-ms?: https://github.com/microsoft/pxt-arcade/commit/4d1263f5549caeb1c3cb4a19a6c89f7982769902

To Reproduce Steps to reproduce the behavior:

  1. Open some game in v1.12.44 or later => Does NOT work with bluetooth HID controller; https://arcade.makecode.com/v1.12.44#editor

Expected behavior Work like it always has always done before in earlier versions(open some game in v1.12.43 or earlier => Works with bluetooth HID controller); https://arcade.makecode.com/v1.12.43#editor

Screenshots See this video of v1.12.44 NOT working: https://github.com/microsoft/pxt-arcade/assets/49032025/89a89a24-d5e2-4b89-a5d6-6e7e9a15f023

See this video of v1.12.43 working: https://github.com/microsoft/pxt-arcade/assets/49032025/0382a46a-e933-47d1-bd01-b76b7daab935

Desktop (please complete the following information):

Additional context Really hope for a fix, since this hinders interesting projects like controlling MCA games with micro:bits programmed in MakeCode and similar creative controllers.

Vegz78 commented 7 months ago

Seems like a related issue on the forum, by @SylviaVargas: https://forum.makecode.com/t/diy-analog-joystick-on-web-editor/25408/7