search

microsoft / pxt-arcade

Arcade game editor based on Microsoft MakeCode
https://arcade.makecode.com
MIT License
484 stars 209 forks source link

Kiosk: Have user-added games display high scores if the game has it #6429

Open srietkerk opened 6 months ago

srietkerk commented 6 months ago

Right now, there are two things that limit the implementation of this feature:

  1. We automatically assign all user-added games to have "HighScore": "None"
  2. Kiosk assumes high scores to be single ascending in the high score list component

Having user-added games with high scores is something that is a delighter for users. Was requested/asked about here: https://forum.makecode.com/t/kiosk-game-high-score-leader-board/28978/1

michaelcaplan commented 6 months ago

Thanks for opening the feature request @srietkerk .

There seems to have been some thought in supporting a diversity of scoring systems with the implemented leader board. The hard coded "SingleAscending" mode defined for the stock games works well for for certain games. I'm guessing (and likely wrong) that is is just for single player largest score scenarios.

I wonder if it would be reasonable to support user added kiosk games that define only this mode as a first stab at making this available to user land games. Future passes at this could look at adding additional modes.

What do you think? Could be some low hanging fruit

srietkerk commented 6 months ago

@michaelcaplan, you are correct that just allowing for single ascending scores for user-added games would be easier than trying to account for different score rankings. However, the work of enabling even single ascending for user-added games is still nuanced because we have to make sure that the game has the correct metadata before hooking it into the high score system. We have to investigate this a bit, so this will take time. The engineering team is currently focused on other workstreams, so we unfortunately can't address this in the near future, but I will make sure to keep you updated.

michaelcaplan commented 6 months ago

@srietkerk appreciate you sharing the context around the complexity of the ask!

srietkerk commented 4 months ago

Hi @michaelcaplan! I have added this feature to the kiosk. Please make sure that when you visit https://arcade.makecode.com/#, under the Settings menu > About the modal says that the arcade version is 1.12.55 and the Microsoft MakeCode version is 8.5.66 like so: image

If that is the case, when you visit kiosk, you can upload a game and see the high scores of the game (as long as you get a score). This includes if a game has low scores as the top score! Please play with this and let me know what you think or if you encounter any difficulties or edge cases.