microsoft / pxt-arcade

Arcade game editor based on Microsoft MakeCode
https://arcade.makecode.com
MIT License
477 stars 207 forks source link

Kiosk: make locked mode not allow more submitted games #6440

Open srietkerk opened 3 months ago

srietkerk commented 3 months ago

If a kiosk code is generated and live, a user can submit games to the kiosk even if the kiosk is locked. So, if a teacher has given out a kiosk code to have students upload their games and then has locked the kiosk to "stop/close submissions" and a student submits a game, that game will still show up on the kiosk.

When the kiosk is locked, it should not display any new games.

A solution to this would be to clear out a kiosk's stored code when the kiosk is locked. This would make it so that when the kiosk becomes unlocked, the user would need to generate another code before allowing any more games to be added.

Another possibility would be to block polling from happening when the kiosk is locked. This would mean that students could technically still submit games to the kiosk, but the UI would not display those new games. This would mean that if a teacher unlocks the kiosk while the code is still valid (and possibly after it's invalid, I'm not 100% sure about that) the kiosk would load any games that were submitted to the kiosk and in the queue.