search

microsoft / pxt-arcade

Arcade game editor based on Microsoft MakeCode
https://arcade.makecode.com
MIT License
484 stars 209 forks source link

SimState Included in Shared Project #6474

Closed thsparks closed 2 weeks ago

thsparks commented 1 year ago

Noticed this game on forum which has the .simstate.json file included, but apparently this is supposed to get filtered out: https://arcade.makecode.com/81297-64610-42599-84021

From forum mod tool:

image
thsparks commented 1 year ago

I don't think this is happening on all shares. This is the only one I've noticed. Guessing it may be some edge case.

abchatra commented 1 year ago

What is the impact of this?

jwunderl commented 1 year ago

.simstate.json stores the user settings, so high score information + whatever they've saved as part of the game using the settings apis. It's not like we have third party requests or anything they could be saving tokens for or anything like that, but it's a per user file / shouldn't be included in the share (and as far as I remember we already cut it out most of the time, so it's likely a weird edge case or e.g. maybe vscode-makecode or something)

abchatra commented 4 months ago

This is an arcade issue.

abchatra commented 4 months ago

At least observed in arcade share page.

abchatra commented 2 weeks ago

We don't have a solid repro. Low priority.