search

microsoft / pxt-brainpad

Microsoft MakeCode editor for the GHI Brainpad
https://makecode.brainpad.com/
Other
3 stars 11 forks source link

Site build errors. #115

Closed greg-norris closed 6 years ago

greg-norris commented 6 years ago

Tried bumping pxt and create new version tag. Site won't build now for some reason. Noticed build error earlier when I added and fixed the last tutorials. It builds and works locally. Did I miss a step here?

https://ci2.dot.net/job/Private/job/pxt_project_blue/job/master/job/pxt-brainpad_Push/

pelikhan commented 6 years ago

Looks like itoa is missing. @mmoskal does itoa need to be added to the CODAL-brainpad repo?

mmoskal commented 6 years ago

There's codal::itoa(). Maybe try adding using namespace codal; to platform.h

greg-norris commented 6 years ago

Is this the file you're talking about? In Brainpad.h? There is a using namespace codal; entry @ line 164.

https://github.com/ghi-electronics/codal-brainpad/blob/master/model/BrainPad.h

mmoskal commented 6 years ago

This one https://github.com/Microsoft/pxt-brainpad/blob/master/libs/core/platform.h

pelikhan commented 6 years ago

You should be able to repro the build failure.

pxt buildtarget —local
greg-norris commented 6 years ago

Seem to be getting the same issue, even after adding using namespace codal; to the platform.h file.

greg-norris commented 6 years ago

I think the problem may have been inside the LightBulb tutorial, I thought was fixed. After removing the tutorial and re-tagging everything, the site is building properly now. I will look at the Tut and find the issue.

Turns out, when I changed the LightBulb tut, I renamed the link to use all lowercase, but never changed the lightBulb.md file to all lower case. Sorry, and Thanks!